mirror of
https://github.com/gohugoio/hugo.git
synced 2024-07-04 16:21:57 +00:00
2e954d8551
If you don't have access to the root domain of your site (eg a GitHub project page) and you try to generate custom permalinks, they must begin with a slash. Go's URL resolution library sees the leading slash and thinks "this URL starts at the root", just like a filesystem - so it discards your subdomain and maps all custom permalinks from the root of your site. Fine if you control the root domain, not so useful if you don't. Removing the check for a leading slash fixes this problem. You can now specify custom permalinks that do not start with a slash, and they will map safely regardless of what subdomain you upload the generated site under. Tests have been updated for this commit so that they continue to function.
75 lines
1.9 KiB
Go
75 lines
1.9 KiB
Go
package hugolib
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// testdataPermalinks is used by a couple of tests; the expandsTo content is
|
|
// subject to the data in SIMPLE_PAGE_JSON.
|
|
var testdataPermalinks = []struct {
|
|
spec string
|
|
valid bool
|
|
expandsTo string
|
|
}{
|
|
{"/:year/:month/:title/", true, "/2012/04/spf13-vim-3.0-release-and-new-website/"},
|
|
{"/:title", true, "/spf13-vim-3.0-release-and-new-website"},
|
|
{":title", true, "spf13-vim-3.0-release-and-new-website"},
|
|
{"/blog/:year/:yearday/:title", true, "/blog/2012/97/spf13-vim-3.0-release-and-new-website"},
|
|
{"/blog/:fred", false, ""},
|
|
{"/:year//:title", false, ""},
|
|
{
|
|
"/:section/:year/:month/:day/:weekdayname/:yearday/:title",
|
|
true,
|
|
"/blue/2012/04/06/Friday/97/spf13-vim-3.0-release-and-new-website",
|
|
},
|
|
{
|
|
"/:weekday/:weekdayname/:month/:monthname",
|
|
true,
|
|
"/5/Friday/04/April",
|
|
},
|
|
{
|
|
"/:slug/:title",
|
|
true,
|
|
"/spf13-vim-3-0-release-and-new-website/spf13-vim-3.0-release-and-new-website",
|
|
},
|
|
}
|
|
|
|
func TestPermalinkValidation(t *testing.T) {
|
|
for _, item := range testdataPermalinks {
|
|
pp := PathPattern(item.spec)
|
|
have := pp.validate()
|
|
if have == item.valid {
|
|
continue
|
|
}
|
|
var howBad string
|
|
if have {
|
|
howBad = "validates but should not have"
|
|
} else {
|
|
howBad = "should have validated but did not"
|
|
}
|
|
t.Errorf("permlink spec %q %s", item.spec, howBad)
|
|
}
|
|
}
|
|
|
|
func TestPermalinkExpansion(t *testing.T) {
|
|
page, err := ReadFrom(strings.NewReader(SIMPLE_PAGE_JSON), "blue/test-page.md")
|
|
if err != nil {
|
|
t.Fatalf("failed before we began, could not parse SIMPLE_PAGE_JSON: %s", err)
|
|
}
|
|
for _, item := range testdataPermalinks {
|
|
if !item.valid {
|
|
continue
|
|
}
|
|
pp := PathPattern(item.spec)
|
|
result, err := pp.Expand(page)
|
|
if err != nil {
|
|
t.Errorf("failed to expand page: %s", err)
|
|
continue
|
|
}
|
|
if result != item.expandsTo {
|
|
t.Errorf("expansion mismatch!\n\tExpected: %q\n\tReceived: %q", item.expandsTo, result)
|
|
}
|
|
}
|
|
}
|