mirror of
https://github.com/gohugoio/hugo.git
synced 2024-07-02 15:20:28 +00:00
fae48d7457
When constructing permalinks, ensure that most inputs used as path segments are normalized with PathSpec.MakeSegment instead of PathSpec.URLize. The primary exception to that rule is with taxonomy titles in pageToPermalinkTitle(). The approach taken here is to use URLize for taxonomy pages. Everything else will use MakeSegment. The reason for this exception is that people use taxonomies such as "s1/p1" to generate URLs precisely they way they wish (see #5223). Tests have been added to check for this case. Fixes #4926
85 lines
2.6 KiB
Go
85 lines
2.6 KiB
Go
// Copyright 2015 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package hugolib
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// testdataPermalinks is used by a couple of tests; the expandsTo content is
|
|
// subject to the data in simplePageJSON.
|
|
var testdataPermalinks = []struct {
|
|
spec string
|
|
valid bool
|
|
expandsTo string
|
|
}{
|
|
{":title", true, "spf13-vim-3.0-release-and-new-website"},
|
|
{"/:year-:month-:title", true, "/2012-04-spf13-vim-3.0-release-and-new-website"},
|
|
|
|
{"/:year/:yearday/:month/:monthname/:day/:weekday/:weekdayname/", true, "/2012/97/04/April/06/5/Friday/"}, // Dates
|
|
{"/:section/", true, "/blue/"}, // Section
|
|
{"/:title/", true, "/spf13-vim-3.0-release-and-new-website/"}, // Title
|
|
{"/:slug/", true, "/spf13-vim-3-0-release-and-new-website/"}, // Slug
|
|
{"/:filename/", true, "/test-page/"}, // Filename
|
|
// TODO(moorereason): need test scaffolding for this.
|
|
//{"/:sections/", false, "/blue/"}, // Sections
|
|
|
|
// Failures
|
|
{"/blog/:fred", false, ""},
|
|
{"/:year//:title", false, ""},
|
|
}
|
|
|
|
func TestPermalinkValidation(t *testing.T) {
|
|
t.Parallel()
|
|
for _, item := range testdataPermalinks {
|
|
pp := pathPattern(item.spec)
|
|
have := pp.validate()
|
|
if have == item.valid {
|
|
continue
|
|
}
|
|
var howBad string
|
|
if have {
|
|
howBad = "validates but should not have"
|
|
} else {
|
|
howBad = "should have validated but did not"
|
|
}
|
|
t.Errorf("permlink spec %q %s", item.spec, howBad)
|
|
}
|
|
}
|
|
|
|
func TestPermalinkExpansion(t *testing.T) {
|
|
t.Parallel()
|
|
s := newTestSite(t)
|
|
page, err := s.NewPageFrom(strings.NewReader(simplePageJSON), "blue/test-page.md")
|
|
|
|
if err != nil {
|
|
t.Fatalf("failed before we began, could not parse simplePageJSON: %s", err)
|
|
}
|
|
for _, item := range testdataPermalinks {
|
|
if !item.valid {
|
|
continue
|
|
}
|
|
pp := pathPattern(item.spec)
|
|
result, err := pp.Expand(page)
|
|
if err != nil {
|
|
t.Errorf("failed to expand page: %s", err)
|
|
continue
|
|
}
|
|
if result != item.expandsTo {
|
|
t.Errorf("expansion mismatch!\n\tExpected: %q\n\tReceived: %q", item.expandsTo, result)
|
|
}
|
|
}
|
|
}
|