hugo/markup/goldmark
Bjørn Erik Pedersen 4e14cf7607
Fail with error when double-rendering text in markdownify/RenderString
This commit prevents the most commons case of infinite recursion in link render hooks when the `linkify` option is enabled (see below). This is always a user error, but getting a `stack overflow` (the current stack limit in Go is 1 GB on 64-bit, 250 MB on 32-bit) error isn't very helpful. This fix will not prevent all such errors, though, but we may do better once #9570 is in place.

So, these will fail:

```
<a href="{{ .Destination | safeURL }}" >{{ .Text | markdownify }}</a>
<a href="{{ .Destination | safeURL }}" >{{ .Text | .Page.RenderString }}</a>
```

`.Text` is already rendered to `HTML`. The above needs to be rewritten to:

```
<a href="{{ .Destination | safeURL }}" >{{ .Text | safeHTML }}</a>
<a href="{{ .Destination | safeURL }}" >{{ .Text | safeHTML }}</a>
```

Fixes #8959
2022-03-10 08:19:03 +01:00
..
codeblocks markup/goldmark/codeblocks: Fix slice bounds out of range 2022-03-08 21:50:21 +01:00
goldmark_config markup/goldmark: Default to https for linkify 2022-03-09 22:30:10 +01:00
internal Add Markdown diagrams and render hooks for code blocks 2022-02-24 18:59:50 +01:00
autoid.go all: Format code with gofumpt 2020-12-03 13:12:58 +01:00
autoid_test.go all: Format code with gofumpt 2020-12-03 13:12:58 +01:00
convert.go markup/goldmark: Default to https for linkify 2022-03-09 22:30:10 +01:00
convert_test.go markup/goldmark: Use Ordinal to create default lineanchors 2022-02-25 17:22:43 +01:00
integration_test.go Fail with error when double-rendering text in markdownify/RenderString 2022-03-10 08:19:03 +01:00
render_hooks.go Fail with error when double-rendering text in markdownify/RenderString 2022-03-10 08:19:03 +01:00
toc.go markup: Rename Header(s) to Heading(s) in ToC struct 2021-06-19 18:19:46 +02:00
toc_test.go Add Markdown diagrams and render hooks for code blocks 2022-02-24 18:59:50 +01:00