mirror of
https://github.com/gohugoio/hugo.git
synced 2024-07-07 17:46:05 +00:00
929808190f
The change in lock logic for `partialCached` in 0927cf739f was naive as it didn't consider cached partials calling other cached partials.
This changeset may look on the large side for this particular issue, but it pulls in part of a working branch, introducing `context.Context` in the template execution.
Note that the context is only partially implemented in this PR, but the upcoming use cases will, as one example, include having access to the top "dot" (e.g. `Page`) all the way down into partials and shortcodes etc.
The earlier benchmarks rerun against master:
```bash
name old time/op new time/op delta
IncludeCached-10 13.6ms ± 2% 13.8ms ± 1% ~ (p=0.343 n=4+4)
name old alloc/op new alloc/op delta
IncludeCached-10 5.30MB ± 0% 5.35MB ± 0% +0.96% (p=0.029 n=4+4)
name old allocs/op new allocs/op delta
IncludeCached-10 74.7k ± 0% 75.3k ± 0% +0.77% (p=0.029 n=4+4)
```
Fixes #9519
95 lines
2.4 KiB
Go
95 lines
2.4 KiB
Go
// Copyright 2019 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package collections
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"reflect"
|
|
"testing"
|
|
|
|
qt "github.com/frankban/quicktest"
|
|
"github.com/gohugoio/hugo/deps"
|
|
"github.com/gohugoio/hugo/output"
|
|
"github.com/gohugoio/hugo/tpl"
|
|
)
|
|
|
|
type templateFinder int
|
|
|
|
func (templateFinder) Lookup(name string) (tpl.Template, bool) {
|
|
return nil, false
|
|
}
|
|
|
|
func (templateFinder) HasTemplate(name string) bool {
|
|
return false
|
|
}
|
|
|
|
func (templateFinder) LookupVariant(name string, variants tpl.TemplateVariants) (tpl.Template, bool, bool) {
|
|
return nil, false, false
|
|
}
|
|
|
|
func (templateFinder) LookupVariants(name string) []tpl.Template {
|
|
return nil
|
|
}
|
|
|
|
func (templateFinder) LookupLayout(d output.LayoutDescriptor, f output.Format) (tpl.Template, bool, error) {
|
|
return nil, false, nil
|
|
}
|
|
|
|
func (templateFinder) Execute(t tpl.Template, wr io.Writer, data interface{}) error {
|
|
return nil
|
|
}
|
|
|
|
func (templateFinder) ExecuteWithContext(ctx context.Context, t tpl.Template, wr io.Writer, data interface{}) error {
|
|
return nil
|
|
}
|
|
|
|
func (templateFinder) GetFunc(name string) (reflect.Value, bool) {
|
|
if name == "dobedobedo" {
|
|
return reflect.Value{}, false
|
|
}
|
|
|
|
return reflect.ValueOf(fmt.Sprint), true
|
|
}
|
|
|
|
func TestApply(t *testing.T) {
|
|
t.Parallel()
|
|
c := qt.New(t)
|
|
d := &deps.Deps{}
|
|
d.SetTmpl(new(templateFinder))
|
|
ns := New(d)
|
|
|
|
strings := []interface{}{"a\n", "b\n"}
|
|
|
|
result, err := ns.Apply(strings, "print", "a", "b", "c")
|
|
c.Assert(err, qt.IsNil)
|
|
c.Assert(result, qt.DeepEquals, []interface{}{"abc", "abc"})
|
|
|
|
_, err = ns.Apply(strings, "apply", ".")
|
|
c.Assert(err, qt.Not(qt.IsNil))
|
|
|
|
var nilErr *error
|
|
_, err = ns.Apply(nilErr, "chomp", ".")
|
|
c.Assert(err, qt.Not(qt.IsNil))
|
|
|
|
_, err = ns.Apply(strings, "dobedobedo", ".")
|
|
c.Assert(err, qt.Not(qt.IsNil))
|
|
|
|
_, err = ns.Apply(strings, "foo.Chomp", "c\n")
|
|
if err == nil {
|
|
t.Errorf("apply with unknown func should fail")
|
|
}
|
|
}
|