From ff02d41721a32485c2f232d542d841e78f83fa9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Tue, 8 Mar 2022 19:36:13 +0100 Subject: [PATCH] releaser: Remove the GitHub link syntax around release contributors Fixes #9581 --- releaser/releasenotes_writer.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/releaser/releasenotes_writer.go b/releaser/releasenotes_writer.go index e7d9255e7..5c50e4de4 100644 --- a/releaser/releasenotes_writer.go +++ b/releaser/releasenotes_writer.go @@ -38,7 +38,7 @@ This is a bug-fix release with a couple of important fixes. {{ end }} {{ range .All }} {{- if .GitHubCommit -}} -* {{ .Subject }} {{ .Hash }} {{ . | authorURL }} {{ range .Issues }}{{ . | issue }} {{ end }} +* {{ .Subject }} {{ .Hash }} {{ . | author }} {{ range .Issues }}{{ . | issue }} {{ end }} {{ else -}} * {{ .Subject }} {{ range .Issues }}{{ . | issue }} {{ end }} {{ end -}} @@ -90,7 +90,7 @@ Hugo now has: {{ define "change-section" }} {{ range . }} {{- if .GitHubCommit -}} -* {{ .Subject }} {{ .Hash }} {{ . | authorURL }} {{ range .Issues }}{{ . | issue }} {{ end }} +* {{ .Subject }} {{ .Hash }} {{ . | author }} {{ range .Issues }}{{ . | issue }} {{ end }} {{ else -}} * {{ .Subject }} {{ range .Issues }}{{ . | issue }} {{ end }} {{ end -}} @@ -112,11 +112,8 @@ var templateFuncs = template.FuncMap{ } return fmt.Sprintf(linkTemplate, info.Hash, info.GitHubCommit.HTMLURL) }, - "authorURL": func(info gitInfo) string { - if info.GitHubCommit.Author.Login == "" { - return "" - } - return fmt.Sprintf(linkTemplate, "@"+info.GitHubCommit.Author.Login, info.GitHubCommit.Author.HTMLURL) + "author": func(info gitInfo) string { + return "@" + info.GitHubCommit.Author.Login }, } @@ -165,7 +162,6 @@ func fetchThemeCount() (int, error) { func getReleaseNotesFilename(version string) string { return filepath.FromSlash(fmt.Sprintf("temp/%s-relnotes-ready.md", version)) - } func (r *ReleaseHandler) writeReleaseNotesToTemp(version string, isPatch bool, infosMain, infosDocs gitInfos) (string, error) {