From fabf026f4937bf6fbbb944aa7d6e721839ae4c92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Wed, 14 Nov 2018 17:44:04 +0100 Subject: [PATCH] helpers: Add a comment about file mode for new files See #5434 --- helpers/path.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/helpers/path.go b/helpers/path.go index f5096e62f..92b58de84 100644 --- a/helpers/path.go +++ b/helpers/path.go @@ -563,12 +563,13 @@ func OpenFilesForWriting(fs afero.Fs, filenames ...string) (io.WriteCloser, erro func OpenFileForWriting(fs afero.Fs, filename string) (afero.File, error) { filename = filepath.Clean(filename) // Create will truncate if file already exists. + // os.Create will create any new files with mode 0666 (before umask). f, err := fs.Create(filename) if err != nil { if !os.IsNotExist(err) { return nil, err } - if err = fs.MkdirAll(filepath.Dir(filename), 0777); err != nil { // rwx, rw, r before umask + if err = fs.MkdirAll(filepath.Dir(filename), 0777); err != nil { // before umask return nil, err } f, err = fs.Create(filename)