From fa432b17b349ed7e914af3625187e2c1dc2e243b Mon Sep 17 00:00:00 2001 From: Niklas Fasching Date: Sun, 11 Apr 2021 21:59:26 +0200 Subject: [PATCH] org: Disable broken pretty relative links feature go-org PrettyRelativeLinks rewrites relative org links by - adding `../` in front - removing any `.org` suffix This was meant to play well with hugo pretty urls (which pretty much renders posts in a subdirectory without the file suffix) and allow use of normal org file links to reference other posts. There's a lot of edge cases I didn't consider and multiple bug reports in go-org [1] later I don't think the complexity of handling those edge cases is worth it - so let's disable it. [1] - https://github.com/niklasfasching/go-org/issues/53 - https://github.com/niklasfasching/go-org/commit/5dadf8c4c2924cbb3b93be45f96e1147596ca6f2 (comment) - https://github.com/niklasfasching/go-org/issues/51 --- markup/org/convert.go | 1 - 1 file changed, 1 deletion(-) diff --git a/markup/org/convert.go b/markup/org/convert.go index 845ee3f3b..34043e18d 100644 --- a/markup/org/convert.go +++ b/markup/org/convert.go @@ -52,7 +52,6 @@ func (c *orgConverter) Convert(ctx converter.RenderContext) (converter.Result, e return afero.ReadFile(c.cfg.ContentFs, filename) } writer := org.NewHTMLWriter() - writer.PrettyRelativeLinks = !c.cfg.Cfg.GetBool("uglyURLs") writer.HighlightCodeBlock = func(source, lang string, inline bool) string { highlightedSource, err := c.cfg.Highlight(source, lang, "") if err != nil {