From bea5feb34d5944e6dfc87dd292a85d100573397a Mon Sep 17 00:00:00 2001 From: bep Date: Fri, 3 Apr 2015 21:16:36 +0200 Subject: [PATCH] Return early from DistinctErrorLogger's Printf --- helpers/general.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/helpers/general.go b/helpers/general.go index cf87c04b1..48e7dbd01 100644 --- a/helpers/general.go +++ b/helpers/general.go @@ -162,11 +162,12 @@ type DistinctErrorLogger struct { func (l *DistinctErrorLogger) Printf(format string, v ...interface{}) { logStatement := fmt.Sprintf(format, v...) l.RLock() - logged := l.m[logStatement] - l.RUnlock() - if logged { + if l.m[logStatement] { + l.RUnlock() return } + l.RUnlock() + l.Lock() if !l.m[logStatement] { jww.ERROR.Print(logStatement)