transform: Complete test statement coverage

"coverage: 100.0% of statements"
This commit is contained in:
Bjørn Erik Pedersen 2016-02-06 20:50:26 +01:00
parent 08b582e187
commit b21d280c67
2 changed files with 7 additions and 7 deletions

View file

@ -85,9 +85,9 @@ func (l *absurllexer) match(r rune) {
if r == p.r[l.idx] { if r == p.r[l.idx] {
l.matches[j] = true l.matches[j] = true
found = true found = true
if l.checkMatchState(r, j) { // checkMatchState will only return true when r=='=', so
return // we can safely ignore the return value here.
} l.checkMatchState(r, j)
} }
} }
@ -249,9 +249,6 @@ func (l *absurllexer) replace() {
l.matches[i] = false l.matches[i] = false
} }
} }
if p == nil {
panic("illegal state: curr is nil when state is full")
}
l.ms = matchStateNone l.ms = matchStateNone
p.f(l) p.f(l)
} }

View file

@ -36,6 +36,9 @@ const H5_XML_CONTENT_GUARDED = "<?xml version=\"1.0\" encoding=\"utf-8\" standal
// additional sanity tests for replacements testing // additional sanity tests for replacements testing
const REPLACE_1 = "No replacements." const REPLACE_1 = "No replacements."
const REPLACE_2 = "ᚠᛇᚻ ᛒᛦᚦ ᚠᚱᚩᚠᚢᚱ\nᚠᚱᚪ ᚷᛖᚻᚹᛦᛚᚳᚢᛗ" const REPLACE_2 = "ᚠᛇᚻ ᛒᛦᚦ ᚠᚱᚩᚠᚢᚱ\nᚠᚱᚪ ᚷᛖᚻᚹᛦᛚᚳᚢᛗ"
const REPLACE_3 = `End of file: src="/`
const REPLACE_4 = `End of file: srcset="/`
const REPLACE_5 = `Srcsett with no closing quote: srcset="/img/small.jpg do be do be do.`
// Issue: 816, schemaless links combined with others // Issue: 816, schemaless links combined with others
const REPLACE_SCHEMALESS_HTML = `Pre. src='//schemaless' src='/normal' <a href="//schemaless">Schemaless</a>. <a href="/normal">normal</a>. Post.` const REPLACE_SCHEMALESS_HTML = `Pre. src='//schemaless' src='/normal' <a href="//schemaless">Schemaless</a>. <a href="/normal">normal</a>. Post.`
@ -94,7 +97,7 @@ var xml_abs_url_bench_tests = []test{
{H5_XML_CONTENT_GUARDED, H5_XML_CONTENT_GUARDED}, {H5_XML_CONTENT_GUARDED, H5_XML_CONTENT_GUARDED},
} }
var sanity_tests = []test{{REPLACE_1, REPLACE_1}, {REPLACE_2, REPLACE_2}} var sanity_tests = []test{{REPLACE_1, REPLACE_1}, {REPLACE_2, REPLACE_2}, {REPLACE_3, REPLACE_3}, {REPLACE_4, REPLACE_4}, {REPLACE_5, REPLACE_5}}
var extra_tests_html = []test{{REPLACE_SCHEMALESS_HTML, REPLACE_SCHEMALESS_HTML_CORRECT}} var extra_tests_html = []test{{REPLACE_SCHEMALESS_HTML, REPLACE_SCHEMALESS_HTML_CORRECT}}
var abs_url_tests = append(abs_url_bench_tests, append(sanity_tests, extra_tests_html...)...) var abs_url_tests = append(abs_url_bench_tests, append(sanity_tests, extra_tests_html...)...)
var extra_tests_xml = []test{{REPLACE_SCHEMALESS_XML, REPLACE_SCHEMALESS_XML_CORRECT}} var extra_tests_xml = []test{{REPLACE_SCHEMALESS_XML, REPLACE_SCHEMALESS_XML_CORRECT}}