From a1f40084f9dfdd45698dc139c7c481da29fb0b3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Thu, 15 Feb 2018 10:03:24 +0100 Subject: [PATCH] Release 0.36.1 --- temp/0.36.1-relnotes-ready.md | 33 +++++++++++++++++++++++++++++++++ temp/0.36.1-relnotes.md | 32 -------------------------------- 2 files changed, 33 insertions(+), 32 deletions(-) create mode 100644 temp/0.36.1-relnotes-ready.md delete mode 100644 temp/0.36.1-relnotes.md diff --git a/temp/0.36.1-relnotes-ready.md b/temp/0.36.1-relnotes-ready.md new file mode 100644 index 000000000..f4d4fd86f --- /dev/null +++ b/temp/0.36.1-relnotes-ready.md @@ -0,0 +1,33 @@ +This release fixes a multi-thread issue when reprocessing and reusing images across pages. When doing something like this with the same image from a partial used in, say, both the home page and the single page: + +```bash +{{ with $img }} +{{ $big := .Fill "1024x512 top" }} +{{ $small := $big.Resize "512x" }} +{{ end }} +``` + +There would be timing issues making Hugo in some cases trying to process the same image twice at the same time. + +You would experience errors of type: + +```bash +png: invalid format: not enough pixel data +``` + +This commit fixes that by adding a mutex per image. This should also improve the performance, sligthly, as it avoids duplicate work. + +The current workaround before this fix is to always operate on the original: + +```bash +{{ with $img }} +{{ $big := .Fill "1024x512 top" }} +{{ $small := .Fill "512x256 top" }} +{{ end }} +``` +This error was rare (no reports on GitHub or the discussion forum), but very hard to debug for the end user. + +* Fix multi-threaded image processing issue [d8fdffb5](https://github.com/gohugoio/hugo/commit/d8fdffb55268464d54558d6f9cd3874b612dc7c7) [@bep](https://github.com/bep) [#4404](https://github.com/gohugoio/hugo/issues/4404) +* Improve error message in .Render [08521dac](https://github.com/gohugoio/hugo/commit/08521dac8323403933a8fd11acfd16930af5f17d) [@bep](https://github.com/bep) +* Bump Travis/Snapcraft to Go 1.9.4 [fc23a80f](https://github.com/gohugoio/hugo/commit/fc23a80ffd3878b9ba9a160ce37e0e1d8703faf3) [@bep](https://github.com/bep) +* Improve error processing error message [2851af02](https://github.com/gohugoio/hugo/commit/2851af0225cdf6c4e47058979cd22949ed6d1fc0) [@bep](https://github.com/bep) diff --git a/temp/0.36.1-relnotes.md b/temp/0.36.1-relnotes.md deleted file mode 100644 index 94f3be0e0..000000000 --- a/temp/0.36.1-relnotes.md +++ /dev/null @@ -1,32 +0,0 @@ - - -This is a bug-fix release with a couple of important fixes. - - -Hugo now has: - -* 23397+ [stars](https://github.com/gohugoio/hugo/stargazers) -* 448+ [contributors](https://github.com/gohugoio/hugo/graphs/contributors) -* 197+ [themes](http://themes.gohugo.io/) - -## Enhancements - -### Core - -* Improve error message in .Render [08521dac](https://github.com/gohugoio/hugo/commit/08521dac8323403933a8fd11acfd16930af5f17d) [@bep](https://github.com/bep) - -### Other - -* Bump Travis/Snapcraft to Go 1.9.4 [fc23a80f](https://github.com/gohugoio/hugo/commit/fc23a80ffd3878b9ba9a160ce37e0e1d8703faf3) [@bep](https://github.com/bep) -* Improve error processing error message [2851af02](https://github.com/gohugoio/hugo/commit/2851af0225cdf6c4e47058979cd22949ed6d1fc0) [@bep](https://github.com/bep) - -## Fixes - -### Other - -* Fix multi-threaded image processing issue [d8fdffb5](https://github.com/gohugoio/hugo/commit/d8fdffb55268464d54558d6f9cd3874b612dc7c7) [@bep](https://github.com/bep) [#4404](https://github.com/gohugoio/hugo/issues/4404) - - - - -