From 98c12b7b3de0822d39886a4de5f3b18b295e3c3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Sun, 18 Sep 2016 19:52:42 +0200 Subject: [PATCH] Fail early in TestGetRealPath See #2476 --- helpers/path_test.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/helpers/path_test.go b/helpers/path_test.go index bd8f8ed49..9ce61b269 100644 --- a/helpers/path_test.go +++ b/helpers/path_test.go @@ -25,6 +25,8 @@ import ( "testing" "time" + "github.com/stretchr/testify/require" + "github.com/stretchr/testify/assert" "github.com/spf13/afero" @@ -149,16 +151,16 @@ func TestGetRealPath(t *testing.T) { fs := afero.NewOsFs() rp1, err := GetRealPath(fs, d1) - assert.NoError(t, err) + require.NoError(t, err) assert.Equal(t, d1, rp1) sym := filepath.Join(os.TempDir(), "d1sym") err = os.Symlink(d1, sym) + require.NoError(t, err) defer os.Remove(sym) - assert.NoError(t, err) rp2, err := GetRealPath(fs, sym) - assert.NoError(t, err) + require.NoError(t, err) // On OS X, the temp folder is itself a symbolic link (to /private...) // This has to do for now.