From 8d86f1ec6ed7a707c995548799c924ff3948acfc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Sat, 19 Mar 2016 17:12:10 +0100 Subject: [PATCH] Return early from parseOptions --- helpers/pygments.go | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/helpers/pygments.go b/helpers/pygments.go index b6a325000..fe14ad49f 100644 --- a/helpers/pygments.go +++ b/helpers/pygments.go @@ -158,15 +158,18 @@ func init() { func parseOptions(options map[string]string, in string) error { in = strings.Trim(in, " ") - if in != "" { - for _, v := range strings.Split(in, ",") { - keyVal := strings.Split(v, "=") - key := strings.ToLower(strings.Trim(keyVal[0], " ")) - if len(keyVal) != 2 || !pygmentsKeywords[key] { - return fmt.Errorf("invalid Pygments option: %s", key) - } - options[key] = keyVal[1] + + if in == "" { + return nil + } + + for _, v := range strings.Split(in, ",") { + keyVal := strings.Split(v, "=") + key := strings.ToLower(strings.Trim(keyVal[0], " ")) + if len(keyVal) != 2 || !pygmentsKeywords[key] { + return fmt.Errorf("invalid Pygments option: %s", key) } + options[key] = keyVal[1] } return nil