From 7a6192647a4b383cd539df2063388ea380371de6 Mon Sep 17 00:00:00 2001 From: Stefan Neuhaus Date: Sun, 27 May 2018 23:14:34 +0200 Subject: [PATCH] Add a BlackFriday option for rel="nofollow" on external links Add a configuration option "nofollowLinks". When set to "true" the "HTML_NOFOLLOW_LINKS" flag is being passed to Blackfriday. Thereby all *absolute* links will get a "nofollow" value for the "rel" attribute. Fixes #4722 --- docs/content/en/readfiles/bfconfig.md | 5 +++++ helpers/content.go | 6 ++++++ helpers/content_test.go | 2 ++ 3 files changed, 13 insertions(+) diff --git a/docs/content/en/readfiles/bfconfig.md b/docs/content/en/readfiles/bfconfig.md index 2d62c310d..a7e74566a 100644 --- a/docs/content/en/readfiles/bfconfig.md +++ b/docs/content/en/readfiles/bfconfig.md @@ -43,6 +43,11 @@ Blackfriday flag: **`HTML_HREF_TARGET_BLANK`**
Purpose: `true` opens external links **absolute** links in a new window or tab. While the `target="_blank"` attribute is typically used for external links, Blackfriday does that for _all_ absolute links ([ref](https://discourse.gohugo.io/t/internal-links-in-same-tab-external-links-in-new-tab/11048/8)). One needs to make note of this if they use absolute links throughout, for internal links too (for example, by setting `canonifyURLs` to `true` or via `absURL`). +`nofollowLinks` +: default: **`false`**
+ Blackfriday flag: **`HTML_NOFOLLOW_LINKS`**
+ Purpose: `true` creates external links **absolute** links with `nofollow` being added to their `rel` attribute. Thereby crawlers are advised to not follow the link. While the `rel="nofollow"` attribute is typically used for external links, Blackfriday does that for _all_ absolute links. One needs to make note of this if they use absolute links throughout, for internal links too (for example, by setting `canonifyURLs` to `true` or via `absURL`). + `plainIDAnchors` : default **`true`**
Blackfriday flag: **`FootnoteAnchorPrefix` and `HeaderIDSuffix`**
diff --git a/helpers/content.go b/helpers/content.go index d42995519..4a46ecb77 100644 --- a/helpers/content.go +++ b/helpers/content.go @@ -108,6 +108,7 @@ type BlackFriday struct { AngledQuotes bool Fractions bool HrefTargetBlank bool + NofollowLinks bool SmartDashes bool LatexDashes bool TaskLists bool @@ -124,6 +125,7 @@ func newBlackfriday(config map[string]interface{}) *BlackFriday { "smartypantsQuotesNBSP": false, "fractions": true, "hrefTargetBlank": false, + "nofollowLinks": false, "smartDashes": true, "latexDashes": true, "plainIDAnchors": true, @@ -277,6 +279,10 @@ func (c *ContentSpec) getHTMLRenderer(defaultFlags int, ctx *RenderingContext) b htmlFlags |= blackfriday.HTML_HREF_TARGET_BLANK } + if ctx.Config.NofollowLinks { + htmlFlags |= blackfriday.HTML_NOFOLLOW_LINKS + } + if ctx.Config.SmartDashes { htmlFlags |= blackfriday.HTML_SMARTYPANTS_DASHES } diff --git a/helpers/content_test.go b/helpers/content_test.go index 2f8884c55..fe670bd74 100644 --- a/helpers/content_test.go +++ b/helpers/content_test.go @@ -204,6 +204,7 @@ func TestGetHTMLRendererAllFlags(t *testing.T) { {blackfriday.HTML_SMARTYPANTS_ANGLED_QUOTES}, {blackfriday.HTML_SMARTYPANTS_FRACTIONS}, {blackfriday.HTML_HREF_TARGET_BLANK}, + {blackfriday.HTML_NOFOLLOW_LINKS}, {blackfriday.HTML_SMARTYPANTS_DASHES}, {blackfriday.HTML_SMARTYPANTS_LATEX_DASHES}, } @@ -212,6 +213,7 @@ func TestGetHTMLRendererAllFlags(t *testing.T) { ctx.Config.AngledQuotes = true ctx.Config.Fractions = true ctx.Config.HrefTargetBlank = true + ctx.Config.NofollowLinks = true ctx.Config.LatexDashes = true ctx.Config.PlainIDAnchors = true ctx.Config.SmartDashes = true