phoenix/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-07-05 08:42:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

node to page: Only return regular pages in home.Data.Pages

Browse source 
Returning all types is both confusing and too breaking.

All page types can be fetched in .Site.Pages.

Updates #2297
This commit is contained in:
Bjørn Erik Pedersen 2016-11-17 10:29:11 +01:00
parent a843d5d3bb
commit 28031b0897
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
hugolib/node_as_page_test.go
View file

@ -67,7 +67,7 @@ func TestNodesAsPage(t *testing.T) {
assertFileContent(t, filepath.Join("public", "index.html"), false, assertFileContent(t, filepath.Join("public", "index.html"), false,
"Index Title: Home Sweet Home!", "Index Title: Home Sweet Home!",
"Home <strong>Content!</strong>", "Home <strong>Content!</strong>",
"# Pages: 9", "# Pages: 4",
"Date: 2009-01-02", "Date: 2009-01-02",
"Lastmod: 2009-01-03", "Lastmod: 2009-01-03",
"GetPage: Section1 ", "GetPage: Section1 ",
@ -184,8 +184,8 @@ func TestNodesWithNoContentFile(t *testing.T) {
require.Len(t, homePages, 1) require.Len(t, homePages, 1)
homePage := homePages[0] homePage := homePages[0]
require.Len(t, homePage.Data["Pages"], 9) require.Len(t, homePage.Data["Pages"], 4)
require.Len(t, homePage.Pages, 9) // Alias require.Len(t, homePage.Pages, 4)
require.True(t, homePage.Path() == "") require.True(t, homePage.Path() == "")
assertFileContent(t, filepath.Join("public", "index.html"), false, assertFileContent(t, filepath.Join("public", "index.html"), false,

2
hugolib/page.go
View file

@ -1466,7 +1466,7 @@ func (p *Page) prepareData(s *Site) error {
switch p.Kind { switch p.Kind {
case KindPage: case KindPage:
case KindHome: case KindHome:
pages = s.findPagesByKindNotIn(KindHome, s.Pages) pages = s.RegularPages
case KindSection: case KindSection:
sectionData, ok := s.Sections[p.sections[0]] sectionData, ok := s.Sections[p.sections[0]]
if !ok { if !ok {