From 1b4e0c4161fb631add62e77f494a7e62c3619020 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Sun, 15 Apr 2018 09:46:02 +0200 Subject: [PATCH] commands: Remove accidental and breaking space in baseURL flag And added key-trimming to prevent future mishaps. See #4607 --- commands/commands_test.go | 1 + commands/hugo.go | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/commands/commands_test.go b/commands/commands_test.go index 2eefaa2ea..376ca7976 100644 --- a/commands/commands_test.go +++ b/commands/commands_test.go @@ -101,6 +101,7 @@ func TestCommandsPersistentFlags(t *testing.T) { assert.Equal("mylayouts", cfg.GetString("layoutDir")) assert.Equal("mytheme", cfg.GetString("theme")) assert.Equal("mythemes", cfg.GetString("themesDir")) + assert.Equal("https://example.com/b/", cfg.GetString("baseURL")) assert.Equal([]string{"page", "home"}, cfg.Get("disableKinds")) diff --git a/commands/hugo.go b/commands/hugo.go index 41c06c026..e2d447768 100644 --- a/commands/hugo.go +++ b/commands/hugo.go @@ -189,7 +189,7 @@ func initializeFlags(cmd *cobra.Command, cfg config.Provider) { "templateMetricsHints", // Moved from vars. - "baseURL ", + "baseURL", "buildWatch", "cacheDir", "cfgFile", @@ -231,6 +231,7 @@ var deprecatedFlags = map[string]bool{ } func setValueFromFlag(flags *flag.FlagSet, key string, cfg config.Provider, targetKey string) { + key = strings.TrimSpace(key) if flags.Changed(key) { if _, deprecated := deprecatedFlags[strings.ToLower(key)]; deprecated { msg := fmt.Sprintf(`Set "%s = true" in your config.toml.