From 17b21e0af1e716bdc7f80b0b2b19b5e469344b34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Sat, 25 Mar 2017 09:56:00 +0100 Subject: [PATCH] hugolib: Correctly identify "my_index_page.md" The above example was earlier identified as a section page and not a regular page. Fixes #3234 --- hugolib/page.go | 9 ++++++++- hugolib/site_test.go | 14 ++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/hugolib/page.go b/hugolib/page.go index e23434a78..141a71420 100644 --- a/hugolib/page.go +++ b/hugolib/page.go @@ -1859,8 +1859,15 @@ func sectionsFromFilename(filename string) []string { return sections } +const ( + regularPageFileNameDoesNotStartWith = "_index" + + // There can be "my_regular_index_page.md but not /_index_file.md + regularPageFileNameDoesNotContain = helpers.FilePathSeparator + regularPageFileNameDoesNotStartWith +) + func kindFromFilename(filename string) string { - if !strings.Contains(filename, "_index") { + if !strings.HasPrefix(filename, regularPageFileNameDoesNotStartWith) && !strings.Contains(filename, regularPageFileNameDoesNotContain) { return KindPage } diff --git a/hugolib/site_test.go b/hugolib/site_test.go index 7919ba377..b8a5eb211 100644 --- a/hugolib/site_test.go +++ b/hugolib/site_test.go @@ -201,6 +201,20 @@ func TestLastChange(t *testing.T) { require.Equal(t, 2017, s.Info.LastChange.Year(), "Site.LastChange should be set to the page with latest Lastmod (year 2017)") } +// Issue #_index +func TestPageWithUnderScoreIndexInFilename(t *testing.T) { + t.Parallel() + + cfg, fs := newTestCfg() + + writeSource(t, fs, filepath.Join("content", "sect/my_index_file.md"), "---\ntitle: doc1\nweight: 1\ndate: 2014-05-29\n---\n# doc1\n*some content*") + + s := buildSingleSite(t, deps.DepsCfg{Fs: fs, Cfg: cfg}, BuildCfg{SkipRender: true}) + + require.Len(t, s.RegularPages, 1) + +} + // Issue #957 func TestCrossrefs(t *testing.T) { t.Parallel()